fix: Add Accept header to auth metadata request #901
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebasing to the latest changes. I hope you will consider this small fix as it will do wonders for integration in the SAP ecosystem. |
felixweinberger
force-pushed
the
main
branch
from
0845a57 to
c94ba4b
Compare
pcarleton
requested changes
Oct 6, 2025
src/client/auth.test.ts
Outdated
| expect(options.headers).toEqual({ | ||
| "MCP-Protocol-Version": "2025-01-01" | ||
| "MCP-Protocol-Version": "2025-01-01", | ||
| Accept: "application/json", |
There was a problem hiding this comment.
note: this is the substantive part of the test change (rest of the changes in this file are formatting, we separately need to fix formatting all over so we can stop having them creep into changes)
There was a problem hiding this comment.
@pcarleton Should be rebased now with a little less over-formatting and confusing diffs 😄
|
PR has been rebased and the changes should now be less massive with the formatting fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Accept header of 'application/json' to the auth metadata request for the MCP client.
Reason for this being that in some cases, particularly in the SAP ecosystem, auth services have a default of going to a login page/IDP selection screen if the Accept is '/'.
Motivation and Context
Recently I've been working on getting MCP into the ERP world, particularly the SAP sphere. All apps used in this area are typically deployed to the Business Technology Platform (BTP) where auth systems like XSUAA are used.
Unfortunately with the current implementation of the auth metadata fetcher for the client side, the default logic of the XSUAA service comes into play, as it defaults to a login page when a query against the metadata endpoint is made, unless the requester explicitly asks for the JSON content.
Therefore by asking specifically for the metadata as JSON this problem can be avoided, and seeing as the subsequent logic in the client library also depends on the data received being of JSON format, it would make sense.
How Has This Been Tested?
I tested this using our internal implementation and the client returned the metadata as expected.
Breaking Changes
Not to my knowledge.
Types of changes
Checklist
Additional context